Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the accuracy of reading Excel #1209

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Conversation

NuoweiWang
Copy link
Contributor

Description

Regarding these issues:

  1. "can't transfor numeric column" , e.g. string column
  2. all empty column in Excel
  3. “I am ¥¥¥” in csv_colunm_foramt

How Has This Been Tested?

using related excels

Snapshots:

Include snapshots for easier review.

Checklist:

  • [1] My code follows the style guidelines of this project
  • [1 ] I have already rebased the commits and make the commit message conform to the project standard.
  • [1 ] I have performed a self-review of my own code
  • [ 1] I have commented my code, particularly in hard-to-understand areas
  • [1 ] I have made corresponding changes to the documentation
  • Any dependent changes have been merged and published in downstream modules

@csunny
Copy link
Collaborator

csunny commented Feb 27, 2024

Great, thanks for your PR, we will make a test and merge later.

Copy link
Collaborator

@csunny csunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks

@NuoweiWang NuoweiWang requested a review from csunny February 28, 2024 06:02
Copy link
Collaborator

@yhjun1026 yhjun1026 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

@csunny csunny merged commit 0837da4 into eosphoros-ai:main Feb 28, 2024
3 checks passed
@NuoweiWang NuoweiWang deleted the DBGPT-1 branch February 29, 2024 01:49
csunny pushed a commit to oushu1zhangxiangxuan1/DB-GPT that referenced this pull request Mar 1, 2024
Hopshine pushed a commit to Hopshine/DB-GPT that referenced this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants